| From: | Yogesh Sharma <yogesh(dot)sharma(at)catprosystems(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Have better wording for snapshot file reading failure |
| Date: | 2023-09-13 10:02:46 |
| Message-ID: | 193b15a6-c63d-574b-4b26-8f53dfec3083@catprosystems.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/13/23 02:10, Bharath Rupireddy wrote:
> Hi,
>
> When a snapshot file reading fails in ImportSnapshot(), it errors out
> with "invalid snapshot identifier". This message better suits for
> snapshot identifier parsing errors which is being done just before the
> file reading. The attached patch adds a generic file reading error
> message with path to help distinguish if the issue is with snapshot
> identifier parsing or file reading.
>
I suggest error message to include "snapshot" keyword in message, like this:
errmsg("could not open snapshot file \"%s\" for reading: %m",
and also tweak other messages accordingly.
--
Kind Regards,
Yogesh Sharma
PostgreSQL, Linux, and Networking Expert
Open Source Enthusiast and Advocate
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2023-09-13 10:13:09 | Re: Infinite Interval |
| Previous Message | Amit Kapila | 2023-09-13 09:49:24 | Re: [PoC] pg_upgrade: allow to upgrade publisher node |