| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Lots of incorrect comments in nodeFuncs.c |
| Date: | 2021-04-09 00:17:28 |
| Message-ID: | 1939597.1617927448@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> hmm ok. I imagine there must be a better way to say that then since
> it confused at least 1 reader so far. My problem is that I assumed
> "result" meant the result of the function that the comment is written
> in, not the result of evaluating the given expression during
> execution. If that was more clear then I'd not have been misled.
Maybe like
case T_ScalarArrayOpExpr:
/* ScalarArrayOpExpr's result is boolean ... */
coll = InvalidOid; /* ... so it has no collation */
break;
?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-04-09 00:21:52 | Re: Simplify backend terminate and wait logic in postgres_fdw test |
| Previous Message | Peter Lee | 2021-04-09 00:14:16 | Postgresql 13 supported on Solaris 11 O/S on SPARC hardware? |