Re: BUG #4190: sparc64 test suite fails

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Dennis Gilmore" <dennis(at)ausil(dot)us>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #4190: sparc64 test suite fails
Date: 2008-05-23 19:09:34
Message-ID: 19376.1211569774@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

"Dennis Gilmore" <dennis(at)ausil(dot)us> writes:
> errors test fails. the following is the output. which to me indicates it
> passed but gave different output.

No, it failed. The code in question looks like this:

int64 arg1 = PG_GETARG_INT64(0);
int32 arg2 = PG_GETARG_INT32(1);
int64 result;

if (arg2 == 0)
ereport(ERROR,
(errcode(ERRCODE_DIVISION_BY_ZERO),
errmsg("division by zero")));

result = arg1 / arg2;

and the output you are showing indicates that the compiler thought it
could rearrange the code so that the division was executed *despite*
the protective test in front of it.

IMHO, what you have here is a compiler bug, or at least the gcc boys are
going to need to provide a damn good excuse why it's not.

BTW, kindly revert the patch you inserted in the Fedora repository.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Gregory Stark 2008-05-23 20:01:45 Re: BUG #4190: sparc64 test suite fails
Previous Message Martin Saschek 2008-05-23 17:17:35 BUG #4191: Include hint for Windows-like locals in documentation