On February 13, 2019 4:39:21 PM GMT+01:00, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>On 13/02/2019 13:18, Andres Freund wrote:
>> But I don't think the way you did it is acceptable - we can't just
>delay while holding buffer locks, in critical sections, while not
>interruptible.
>
>The code I added to XLogInsertRecord() is not inside the critical
>section.
Most callers do xlog insertions inside crit sections though.
Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.