Re: CLUSTER patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)atentus(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: CLUSTER patch
Date: 2002-07-14 17:03:02
Message-ID: 19267.1026666182@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> + CommandCounterIncrement();
> +
> + // bjm
> + // RelationIdInvalidateRelationCacheByRelationId(r1);
> + // RelationIdInvalidateRelationCacheByRelationId(r2);
> +
> + RelationClearRelation(RelationIdGetRelation(r1), true);
> + // RelationClearRelation(RelationIdGetRelation(r2), true);
> +
> + CommandCounterIncrement();

Surely the above is neither necessary nor appropriate. The relcache
should automatically rebuild its entries for these relations at
CommandCounterIncrement. In any case I do not care for exporting
internal relcache routines to make CLUSTER work ...

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2002-07-14 17:21:00 Re: CLUSTER patch
Previous Message Tom Lane 2002-07-14 16:58:19 Re: CLUSTER patch