From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: array_cat anycompatible change is breaking xversion upgrade tests |
Date: | 2020-11-08 23:47:22 |
Message-ID: | 1915573.1604879242@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I wrote:
> I think the most plausible response is to add this aggregate to the filter
> logic that already exists in the xversion tests. Perhaps we could
> alternatively change this test case so that it relies on some other
> polymorphic function, but I'm not quite sure what a good candidate
> would be.
After looking at the commit that added array_cat_accum() (65d9aedb1),
I decided that it's fine to replace this aggregate with one using another
anyarray function, such as array_larger(). The point of that test is just
to show that the array argument can be array-of-record, so we don't need
the operation to be array_cat() specifically. So I propose the attached
patches to un-break the xversion tests.
I'll hold off pushing this till after this week's wraps, though.
regards, tom lane
Attachment | Content-Type | Size |
---|---|---|
xversion-fix-head.patch | text/x-diff | 2.0 KB |
xversion-fix-back.patch | text/x-diff | 1.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2020-11-09 02:07:34 | Re: Hybrid Hash/Nested Loop joins and caching results from subplans |
Previous Message | Tom Lane | 2020-11-08 23:22:50 | Re: upcoming API changes for LLVM 12 |