Re: BUG #17088: FailedAssertion in prepagg.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, cyg0810(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #17088: FailedAssertion in prepagg.c
Date: 2021-07-07 21:22:17
Message-ID: 1909846.1625692937@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> writes:
> A number of places in the planner have to explicitly avoid recursing
> into GroupingFunc->args when walking trees specifically because they are
> not evaluated. It looks to me like some places where that should have
> been checked for were missed. Looking into it.

Hmm. Maybe it'd be better if the default behavior in
expression_tree_walker/mutator did not include recursing into the args,
then? I am thinking this might be comparable to SubLinks/SubPlans, where
the walker has to take explicit action if it wants to recurse into the
sub-query.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2021-07-07 21:25:50 BUG #17092: SELECT using LIMIT clause without ORDER BY fails when parallel query is on
Previous Message Andrew Gierth 2021-07-07 21:18:01 Re: BUG #17088: FailedAssertion in prepagg.c