Re: pg_dump error - LOCALIZATION PROBLEM

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Erol Öz <eroloz(at)esg(dot)com(dot)tr>, PostgreSQL General List <pgsql-general(at)postgresql(dot)org>
Subject: Re: pg_dump error - LOCALIZATION PROBLEM
Date: 2001-09-16 21:57:39
Message-ID: 19075.1000677459@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Untested, but try this:

> Edit src/backend/commands/variable.c, look for the function
> parse_XactIsoLevel(). Change the code that looks like this:

> if (strcasecmp(value, "SERIALIZABLE") == 0)
> XactIsoLevel = XACT_SERIALIZABLE;
> else if (strcasecmp(value, "COMMITTED") == 0)
> XactIsoLevel = XACT_READ_COMMITTED;

> into:

> if (strcmp(value, "serializable") == 0)
> XactIsoLevel = XACT_SERIALIZABLE;
> else if (strcmp(value, "committed") == 0)
> XactIsoLevel = XACT_READ_COMMITTED;

Hmm. Given that we expect the lexer to have downcased any unquoted
words, this seems like a workable solution --- where else are we using
strcasecmp() unnecessarily?

regards, tom lane

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Bolt Thrower 2001-09-16 22:23:15 sequences: log_cnt?
Previous Message Tom Lane 2001-09-16 21:13:52 Re: Questions about tuning on FreeBSD...

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2001-09-16 23:04:18 Re: pg_dump error - LOCALIZATION PROBLEM
Previous Message Tom Lane 2001-09-16 21:48:14 Re: dynamic-static date once again