Re: logical decoding bug: segfault in ReorderBufferToastReplace()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, "Schneider (AWS), Jeremy" <schnjere(at)amazon(dot)com>
Subject: Re: logical decoding bug: segfault in ReorderBufferToastReplace()
Date: 2019-12-11 17:11:03
Message-ID: 19042.1576084263@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-committers pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> This indicates that a toast record was present for that relation,
> despite:
> [ \d that looks like the table isn't wide enough for that ]
> I think we need to see pg_waldump output for the preceding records. That
> might allow us to see why there's a toast record that's being associated
> with this table, despite there not being a toast table.

I don't think you can make that conclusion. Perhaps the table once
needed a toast table because of some wide column that got dropped;
if so, it'd still have one. It'd be safer to look at
pg_class.reltoastrelid to verify existence (or not) of the toast relation.

It strikes me that there could easily be cases where a publisher table
has a toast relation and a subscriber's doesn't ... maybe this code
isn't expecting that?

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Robert Haas 2019-12-11 17:12:48 Re: logical decoding bug: segfault in ReorderBufferToastReplace()
Previous Message Tom Lane 2019-12-11 16:49:09 Re: Memory leak (possibly connected to postgis) leading to server crash

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2019-12-11 17:12:48 Re: logical decoding bug: segfault in ReorderBufferToastReplace()
Previous Message Andres Freund 2019-12-11 16:35:22 Re: logical decoding bug: segfault in ReorderBufferToastReplace()

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2019-12-11 17:12:48 Re: logical decoding bug: segfault in ReorderBufferToastReplace()
Previous Message Andres Freund 2019-12-11 16:54:25 Re: error context for vacuum to include block number