From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p ... |
Date: | 2004-05-19 18:21:11 |
Message-ID: | 19032.1084990871@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> And tested? I didn't say that I thought elog would work in main.c.
>> In fact I'm pretty certain it won't.
> Compiles/regression tests pass.
You need to test the cases that will produce elog output.
> This is why I removed elog in the first place, because I thought it
> wouldn't work up higher before the guc load, but you said it would use
> the default. Are you saying it only works after guc is loaded?
No, I specifically said it didn't need guc. But it does need palloc,
which means MemoryContextInit() has to run first. I could see running
find_my_exec immediately before InitializeGUCOptions() in PostmasterMain.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-05-19 18:58:45 | pgsql-server/src/backend main/main.c postmaste ... |
Previous Message | Bruce Momjian | 2004-05-19 17:37:45 | Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p ... |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-05-19 19:02:10 | Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p |
Previous Message | Magnus Hagander | 2004-05-19 18:03:31 | Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p ... |