| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Christensen <david(dot)christensen(at)crunchydata(dot)com> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Shinya11(dot)Kato(at)nttdata(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] expand the units that pg_size_pretty supports on output |
| Date: | 2021-07-07 19:31:00 |
| Message-ID: | 1903029.1625686260@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Christensen <david(dot)christensen(at)crunchydata(dot)com> writes:
> Enclosed is the patch to change the return type to numeric, as well as one for expanding units to
> add PB and EB.
Can we really get away with changing the return type? That would
by no stretch of the imagination be free; one could expect breakage
of a few user views, for example.
Independently of that, I'm pretty much -1 on going further than PB.
Even if the additional abbreviations you mention are actually recognized
standards, I think not that many people are familiar with them, and such
input is way more likely to be a typo than intended data.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Christensen | 2021-07-07 19:56:46 | Re: [PATCH] expand the units that pg_size_pretty supports on output |
| Previous Message | Tom Lane | 2021-07-07 19:22:06 | Re: PostgreSQL 14 backend crash on incorrect trigger |