| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: alter subscription drop publication fixes |
| Date: | 2021-05-14 15:26:18 |
| Message-ID: | 1885279.1621005978@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> writes:
> On Fri, May 14, 2021 at 7:58 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>> I have changed it to:
>> <literal>ADD</literal> adds additional publications,
>> - <literal>DROP</literal> removes publications from the list of
>> + <literal>DROP</literal> removes publications to/from the list of
> How about "Publications are added to or dropped from the existing list
> of publications by <literal>ADD</literal> or <literal>DROP</literal>
> respectively." ?
We generally prefer to use the active voice, so I don't think
restructuring the sentence that way is an improvement. The quoted
bit would be better left alone entirely. Or maybe split it into
two sentences, but keep the active voice.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chapman Flack | 2021-05-14 15:33:34 | Re: allow specifying direct role membership in pg_hba.conf |
| Previous Message | Tom Lane | 2021-05-14 15:23:20 | Re: allow specifying direct role membership in pg_hba.conf |