| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Sokolov Yura <funny(dot)falcon(at)postgrespro(dot)ru> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org |
| Subject: | Re: Fix performance of generic atomics |
| Date: | 2017-09-06 13:36:36 |
| Message-ID: | 18851.1504704996@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Sokolov Yura <funny(dot)falcon(at)postgrespro(dot)ru> writes:
> On 2017-09-06 15:56, Tom Lane wrote:
>> The point I'm trying to make is that if tweaking generic.h improves
>> performance then it's an indicator of missed cases in the less-generic
>> atomics code, and the latter is where our attention should be focused.
>> I think basically all of the improvement Sokolov got was from upgrading
>> the coverage of generic-gcc.h.
> Not exactly. I've checked, that new version of generic
> pg_atomic_fetch_or_u32
> loop also gives improvement.
But once you put in the generic-gcc version, that's not reached anymore.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-09-06 13:38:35 | Re: [COMMITTERS] pgsql: Add psql variables showing server version and psql version. |
| Previous Message | Sokolov Yura | 2017-09-06 13:31:53 | Re: Fix performance of generic atomics |