Re: COPY CSV keywords

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: COPY CSV keywords
Date: 2004-04-20 14:41:32
Message-ID: 18851.1082472092@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Peter Eisentraut wrote:
>> Bruce Momjian wrote:
>>> LITERAL - prevent NULL checks for specific columns
>>
>> NO NULL CHECK

> I considered going this direction, but it broke the WITH clause style of
> COPY.

Huh? Many of the other options are already potentially two words,
eg QUOTE [AS], so I don't see how you can object to that aspect.

I agree with Peter that "LITERAL" is a completely unhelpful name for the
functionality.

"NO NULL CHECK" seems a bit confusing as well --- at first glance it
looks like it might mean overriding the column's NOT NULL attribute
(which I trust is not what it means ;-)). Perhaps "NO NULLS" ?
Or just "NOT NULL", to avoid introducing another keyword.

I liked the "FORCE QUOTE" suggestion, too.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-04-20 14:49:34 Re: COPY CSV keywords
Previous Message Bruce Momjian 2004-04-20 14:33:49 Re: [PATCHES] CSV patch applied

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-04-20 14:49:34 Re: COPY CSV keywords
Previous Message Bruce Momjian 2004-04-20 14:37:13 Re: NetBSD 2.0 / native threads