Re: Refactor compile-time assertion checks for C/C++

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Georgios Kokolatos <gkokolatos(at)pm(dot)me>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Refactor compile-time assertion checks for C/C++
Date: 2020-03-13 15:00:33
Message-ID: 1880.1584111633@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> Hmm. v3 actually broke the C++ fallback of StaticAssertExpr() and
> StaticAssertStmt() (v1 did not), a simple fix being something like
> the attached.

The buildfarm seems happy, so why do you think it's broken?

If we do need to change it, I'd be inclined to just use the do{}
block everywhere, not bothering with the extra #if test.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thunder 2020-03-13 15:00:55 Optimize crash recovery
Previous Message Tom Lane 2020-03-13 14:56:15 Re: make check crashes on POWER8 machine