| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Failed Assert in pgstat_assoc_relation |
| Date: | 2022-12-02 05:48:48 |
| Message-ID: | 1874115.1669960128@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2022-12-02 00:08:20 -0500, Tom Lane wrote:
>> Just the table-to-view hack. I'm not aware that there are any other
>> cases, and it seems hard to credit that there ever will be any.
> I can see some halfway credible scenarios. E.g. converting a view to a
> matview, or a table into a partition. I kind of wonder if it's worth keeping
> the change, just in case we do - it's not that easy to hit...
I'd suggest putting in an assertion that the relkind isn't changing,
instead. When and if somebody makes a credible feature patch that'd
require relaxing that, we can see what to do.
(There's a couple of places in rewriteHandler.c that could
perhaps be simplified, too.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2022-12-02 05:50:00 | Re: Introduce a new view for checkpointer related stats |
| Previous Message | John Naylor | 2022-12-02 05:41:06 | Re: [PATCH] Add native windows on arm64 support |