From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | include-file cleanup |
Date: | 1999-07-16 23:29:36 |
Message-ID: | 18727.932167776@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
It took a little work to recompile after the include-file cleanups :-(.
You got overenthusiastic about removing #includes, apparently.
I have checked in changes for the ones that caused compile failures
or warnings here, but there may be more.
One thing that particularly disturbs me is that "config.h" was removed
from some of the files in src/backend/port/. I had to put this back
in the ones used on my platform. I didn't touch anything I didn't get
a warning from, but I would strongly counsel making sure that config.h
still gets included *everywhere*, even if it doesn't seem necessary.
Failing to do so may cause subtle problems due to #define symbols not
being defined where they should be or prototypes not being visible that
should be. This is especially dangerous in platform-specific code.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Wayne Piekarski | 1999-07-17 03:23:22 | Re: Oversize proc sources (was Re: [BUGS] Backend dies creating plpgsql procedures (with reproducible example!)) |
Previous Message | Tom Lane | 1999-07-16 23:01:41 | Re: AW: [HACKERS] shared lib names |