From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Kurt Harriman <harriman(at)acm(dot)org> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Patch: Remove gcc dependency in definition of inline functions |
Date: | 2010-01-19 00:42:28 |
Message-ID: | 18718.1263861748@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Kurt Harriman <harriman(at)acm(dot)org> writes:
> c) Use configure to automate the testing of each build environment
> in situ.
> The third alternative adapts to new or little-known platforms
> with little or no manual intervention.
This argument is bogus unless you can demonstrate a working configure
probe for the property in question. The question about this patch,
from day one, has been whether we have a working configure test.
> It is true that configure doesn't need to test for MSVC's
> __forceinline keyword. I included that mainly as a placeholder
> for the benefit of future hackers: likely someone will
> discover a need for a special keyword to suppress another
> compiler's warnings.
I think including MSVC in the set of compilers targeted by a configure
test is just a waste of code. It's more likely to confuse people than
help them.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Hitoshi Harada | 2010-01-19 00:48:32 | Re: review: More frame options in window functions |
Previous Message | Takahiro Itagaki | 2010-01-19 00:40:07 | Re: Pretty printed trigger in psql |