Re: SPI function to investigate query semantics

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Hallgren <thhal(at)mailblocks(dot)com>
Cc: "pgsql-patches(at)postgresql(dot)org" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: SPI function to investigate query semantics
Date: 2004-12-01 20:27:22
Message-ID: 18705.1101932842@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Thomas Hallgren <thhal(at)mailblocks(dot)com> writes:
> Tom Lane wrote:
>> You do realize that SPI_execute will reject TransactionStmt anyway?
>> The example is therefore not very compelling ...
>>
> It won't reject savepoint related statements and that's what the example
> is for.

Really?

if (queryTree->commandType == CMD_UTILITY)
{
...
else if (IsA(queryTree->utilityStmt, TransactionStmt))
{
res = SPI_ERROR_TRANSACTION;
goto fail;
}
}

Looks pretty rejectish to me...

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Thomas Hallgren 2004-12-01 20:27:58 Re: SPI function to investigate query semantics
Previous Message Thomas Hallgren 2004-12-01 20:24:46 Re: SPI function to investigate query semantics