Re: Ensuring hash tuples are properly maxaligned

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Ensuring hash tuples are properly maxaligned
Date: 2018-01-03 01:49:17
Message-ID: 18676.1514944157@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2018-01-02 20:40:50 -0500, Tom Lane wrote:
>> OK, then there's not a live bug, but I'm a bit tempted to get rid of
>> the data[] member anyway. It's not clear to me now that keeping it
>> results in net cleaner code. Thoughts?

> I like that plan. I don't think the data field buys us anything, and I
> personally in most cases find "fully manual" alignment code easier to
> reason about than fiddling with padding fields.

Agreed --- I'll go do that.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2018-01-03 01:52:48 Re: Contributing with code
Previous Message Andres Freund 2018-01-03 01:43:55 Re: Ensuring hash tuples are properly maxaligned