From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Victor Wagner <vitus(at)wagner(dot)pp(dot)ru> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: master make check fails on Solaris 10 |
Date: | 2018-01-17 15:40:26 |
Message-ID: | 18638.1516203626@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Victor Wagner <vitus(at)wagner(dot)pp(dot)ru> writes:
> On Wed, 17 Jan 2018 10:07:37 -0500
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Yeah, I can work with this. What I propose to do is use a somewhat
>> stripped-down version of this test as an AC_RUN_IFELSE test normally,
>> but if cross-compiling, fall back to just seeing if we can link.
> I'd suggest to add a configure option to switch off 128-bit support
> (--disable-int128), especially for these cross-compile cases where link
> test cannot give us enough information to decide automatically.
I don't want to go there without some evidence that the problem is much
more widespread than it appears now. A disable switch will be a permanent
documentation and maintenance overhead, plus anyone who puts it into
their build scripts will probably never remember to remove it :-(.
And how many people will be cross-compiling to Solaris/SPARC anyway?
(If there are any, they can always manually change pg_config.h ...)
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-01-17 15:42:46 | Re: master make check fails on Solaris 10 |
Previous Message | Victor Wagner | 2018-01-17 15:32:29 | Re: master make check fails on Solaris 10 |