Re: [PATCH] Extending pg_class info + more flexible TOAST chunk size

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Extending pg_class info + more flexible TOAST chunk size
Date: 2008-10-13 01:00:02
Message-ID: 18603.1223859602@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
> Bacause MAX_TOAST_CHUNK_SIZE is related on page layout version I need have toast
> chunk size more flexible.

> Attached patch add three new columns into pg_class

> relblocksize - which is always BLCKSZ. I put it there for fullness, but i could
> be use in future development to specify different BLCKSZ per relation.

> relsegsize - currently it is always RELSEG_FILE. I performed basic adjustment in
> smgr.c and md.c. Now only smgropen contains reference to RELSEG_FILE. The
> problem how to do it fully dynamic is how to pass information rel_rd->relsegsize
> down into smgropen. One idea is to extend relfilenode, but I'm not sure about it.

> relmaxitemsize - it is set to TOAST_MAX_CHUNK_SIZE. Other relation has this
> value set to zero for now. toast functions are fully aware about this setting
> and use it. This column will be convert to int2vector during pg_upgrade
> development (I need to track information for each page version).

There is not one of these things that we have any intention of being
allowed to vary on a per-relation basis. Why don't you read them out of
pg_control?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message ITAGAKI Takahiro 2008-10-13 01:36:59 Re: [PATCH] Extending pg_class info + more flexible TOAST chunk size
Previous Message Tom Lane 2008-10-13 00:44:09 Re: recursive query crash