| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Making tab-complete.c easier to maintain |
| Date: | 2015-12-18 20:42:50 |
| Message-ID: | 1851.1450471370@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> [ tab-complete-macrology-v11.patch.gz ]
A couple of stylistic reactions after looking through the patch for the
first time in a long time:
1. It seems inconsistent that all the new macros are named in CamelCase
style, whereas there is still plenty of usage of the existing macros like
COMPLETE_WITH_LIST. It looks pretty jarring IMO. I think we should
either rename the new macros back to all-upper-case style, or rename the
existing macros in CamelCase style.
I slightly favor the latter option; we're already pretty much breaking any
hope of tab-complete fixes applying backwards over this patch, so changing
the code even more doesn't seem like a problem. Either way, it's a quick
search-and-replace. Thoughts?
2. Why does MatchAnyExcept use "'" as the inversion flag, rather than
say "!" or "~" ? Seems pretty random.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-12-18 20:47:51 | Re: Getting sorted data from foreign server for merge join |
| Previous Message | Tom Lane | 2015-12-18 20:21:58 | Re: Making tab-complete.c easier to maintain |