Re: pgsql: Some refactoring of logical/worker.c

From: Erik Rijkers <er(at)xs4all(dot)nl>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Some refactoring of logical/worker.c
Date: 2020-03-24 14:39:16
Message-ID: 1849f82eaac5f2edb59ecaa6b79112ac@xs4all.nl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2020-03-24 15:17, Peter Eisentraut wrote:
> Some refactoring of logical/worker.c
>
> Discussion:
> https://www.postgresql.org/message-id/flat/CA+HiwqH=Y85vRK3mOdjEkqFK+E=ST=eQiHdpj43L=_eJMOOznQ(at)mail(dot)gmail(dot)com
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/97ee604d9bcedf0066986521a7ee15e3aa87be34
>
> Modified Files
> --------------
> src/backend/replication/logical/worker.c | 174
> ++++++++++++++++++++-----------
> 1 file changed, 115 insertions(+), 59 deletions(-)

gcc 9.3.0 mutters under its breath,

worker.c: In function ‘apply_handle_update_internal’:
worker.c:791:22: warning: unused variable ‘remoterel’
[-Wunused-variable]
791 | LogicalRepRelation *remoterel = &relmapentry->remoterel;
|

Otherwise the build is fine (documentation build too, including .pdf,
thanks Tom)

Erik Rijkers

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2020-03-24 15:02:17 pgsql: Fix compiler warning
Previous Message Tom Lane 2020-03-24 14:27:28 pgsql: Doc: fix broken markup.