Re: patch: autocomplete for functions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch: autocomplete for functions
Date: 2012-03-19 19:53:49
Message-ID: 18481.1332186829@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On fre, 2012-03-16 at 13:47 -0400, Tom Lane wrote:
>> I'm a bit concerned about whether that's actually going to be useful.
>> A quick check shows that in the regression database, the proposed patch
>> produces 3246 possible completions, which suggests that by the time you
>> get down to a unique match you're going to have typed most of the name
>> anyway.

> Well, the regression test database is not really an example of real-life
> object naming, I think.

Perhaps not, but a solid 2000 of those names are from the system-created
entries in pg_proc, and the regression DB doesn't have an especially
large number of tables either. I doubt that real DBs are likely to have
materially fewer completions.

This connects somewhat to the discussions we've had in the past about
trying to get not-intended-for-public-use functions out of the standard
search path. Not that you want to put a full visibility check into the
tab-completion query, but if it could simply exclude a "pg_private"
namespace, that probably wouldn't be too expensive.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2012-03-19 19:55:55 Re: Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)
Previous Message Heikki Linnakangas 2012-03-19 19:49:45 Re: Regarding column reordering project for GSoc 2012