From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | lei(at)aswsyst(dot)cz |
Cc: | pgsql-bugs(at)postgresql(dot)org |
Subject: | Re: BUG #13638: Exception texts from plperl has bad encoding |
Date: | 2015-09-25 19:33:44 |
Message-ID: | 18478.1443209624@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
I wrote:
> I suspect the root problem is that instead of baldly doing
> croak("%s", edata->message);
> in do_util_elog(), we need to do something to inform Perl what encoding
> the message string is in. This is beyond my Perl-fu, however.
BTW, if the answer to that involves turning the message back into an SV,
I think we should not do that but just use the SV that was passed in
originally. Then the TRY/CATCH could go away entirely, ie the code
would become roughly like
if (level < ERROR)
{
cmsg = sv2cstr(msg);
elog(level, "%s", cmsg);
pfree(cmsg);
}
else
{
croak-with-SV(msg);
}
which knows slightly more about the meaning of "level" than before,
but otherwise seems much less entangled with anything.
It's still beyond my Perl-fu ...
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2015-09-25 19:51:20 | Re: BUG #13638: Exception texts from plperl has bad encoding |
Previous Message | Tom Lane | 2015-09-25 19:18:28 | Re: BUG #13638: Exception texts from plperl has bad encoding |