| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Gunther <raj(at)gusw(dot)net>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-performance(at)lists(dot)postgresql(dot)org, Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Subject: | Re: Out of Memory errors are frustrating as heck! |
| Date: | 2019-04-15 17:45:00 |
| Message-ID: | 18440.1555350300@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-performance |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Seems that ExecHashJoinGetSavedTuple stores a minimalTuple and sets the
> shouldFree flag to "true", and then in ExecHashJoinNewBatch, callee
> ExecFetchSlotMinimalTuple sets shouldFree to false inconditionally when
> the slot uses minimal tuple ops. Maybe that's correct, but it does
> sound like a memory leak is not entirely impossible. I wonder if this
> fixes it, without causing crashes elsewhere.
This discussion is about v11, not HEAD. Still, I agree that that
coding in HEAD seems a bit fishy.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Janes | 2019-04-15 18:14:07 | Re: Out of Memory errors are frustrating as heck! |
| Previous Message | Alvaro Herrera | 2019-04-15 17:38:48 | Re: Out of Memory errors are frustrating as heck! |