Re: run pgindent on a regular basis / scripted manner

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: Jelte Fennema <postgres(at)jeltef(dot)nl>, Andrew Dunstan <andrew(at)dunslane(dot)net>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Noah Misch <noah(at)leadboat(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Jesse Zhang <sbjesse(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: run pgindent on a regular basis / scripted manner
Date: 2023-04-24 14:14:31
Message-ID: 183836.1682345671@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> Does anyone find perltidy useful? To me, it functions more like a
> JavaScript compiler in that once you process the source code, it is no
> longer useful for manual editing. If we are going to have the buildfarm
> check indentation and that is going to be extended to Perl code, I have
> some concerns about that.

I certainly don't like its current behavior where adding/changing one
line can have side-effects on nearby lines. But we have a proposal
to clean that up, and I'm cautiously optimistic that it'll be better
in future. Did you have other specific concerns?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2023-04-24 14:14:34 Re: Add missing copyright for pg_upgrade/t/* files
Previous Message Tom Lane 2023-04-24 14:11:25 Re: Memory leak in CachememoryContext