Re: Frustrating issue with PGXS

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fabien COELHO <fabien(dot)coelho(at)ensmp(dot)fr>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Eddie Stanley <eddiewould(at)paradise(dot)net(dot)nz>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>, mux(at)elvis(dot)mu(dot)org
Subject: Re: Frustrating issue with PGXS
Date: 2007-06-26 14:12:16
Message-ID: 18357.1182867136@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fabien COELHO <fabien(dot)coelho(at)ensmp(dot)fr> writes:
> But ISTM that the remedy (breaking all past makefiles for all extensions)
> is not worth the issue.
> A better documentation, and possibly following your suggestion with an
> explicit PG_CONFIG in contrib makefiles, but without breaking existing
> extensions seems quite enough. The error made by Eddie is legitimate, but
> it is also something rare, it did not come up in the last two years.

True. OK, then let's add the ifndef to Makefile.global and change the
existing extension makefiles to

PG_CONFIG := pg_config
PGXS := $(shell $(PG_CONFIG) --pgxs)
include $(PGXS)

Any objections?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message A.M. 2007-06-26 14:17:32 Re: no cascade triggers?
Previous Message Chris Mair 2007-06-26 14:04:28 no cascade triggers?