Re: Rethinking MemoryContext creation

Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> writes:
> On 12/10/2017 04:42 PM, Tom Lane wrote:
>> Peter Geoghegan <pg(at)bowt(dot)ie> writes:
>>> On Sat, Dec 9, 2017 at 5:53 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>>> Overall I'm seeing about a 5% improvement in a "pgbench -S" scenario,
>>>> although that number is a bit shaky since the run-to-run variation
>>>> is a few percent anyway.

> FWIW I've done some measurements, and while there is a improvement, it's
> far from 5%. ...
> So that's about 1.3% and 1.2% improvement. It seems fairly consistent,
> but it might easily be due to different in layout of the binaries.

Thanks for checking. With these sorts of small-percentage improvements,
I would not be surprised for platform-to-platform results to be different.
At least you do see some improvement too.

Let me code up the change to avoid copying constant name strings,
and then we can see if that helps any.

regards, tom lane