| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | Tender Wang <tndrwang(at)gmail(dot)com>, Duncan Sands <duncan(dot)sands(at)deepbluecap(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Attribute of type record has wrong type error with MERGE ... WHEN NOT MATCHED BY SOURCE THEN DELETE |
| Date: | 2025-03-11 21:51:21 |
| Message-ID: | 1834982.1741729881@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
I wrote:
> Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> writes:
>> Maybe we need to not clear rte->functions, and use that
>> instead.
> I'll have a go at coding it that way...
Yeah, that is a better way. In exchange for a slightly dirtier
data structure, we now have essentially all the relevant code in
makeWholeRowVar: correctness only depends on its different case
branches agreeing, rather than on some not-terribly-similar code
way over in prepjointree.c.
I also took the opportunity to split off the old-branch adjustment
of rewriteHandler.c, so that the HEAD and v15 versions of the main
bug fix patch are nearly the same.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| v3-generate-correct-vartype-for-whole-row-vars-HEAD.patch | text/x-diff | 6.5 KB |
| v3-0001-preserve-relid-15.patch | text/x-diff | 1.6 KB |
| v3-0002-generate-correct-vartype-for-whole-row-vars-15.patch | text/x-diff | 6.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Wright | 2025-03-11 21:54:03 | Re: Unqualified name not resolved in function called from materialized view (17.4) |
| Previous Message | Tom Lane | 2025-03-11 20:06:04 | Re: Attribute of type record has wrong type error with MERGE ... WHEN NOT MATCHED BY SOURCE THEN DELETE |