| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Georgios Kokolatos <gkokolatos(at)pm(dot)me> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Subject: | Re: ALTER TEXT SEARCH DICTIONARY tab completion |
| Date: | 2020-03-07 22:00:50 |
| Message-ID: | 18323.1583618450@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Georgios Kokolatos <gkokolatos(at)pm(dot)me> writes:
> One minor nitpick I feel I should add is that for completeness and
> balance the equivalent `CREATE TEXT SEARCH DICTIONARY` should
> get the same treatment.
> Maybe something along the lines of:
> - else if (Matches("CREATE", "TEXT", "SEARCH", "CONFIGURATION", MatchAny))
> + else if (Matches("CREATE", "TEXT", "SEARCH", "DICTIONARY|CONFIGURATION", MatchAny))
Agreed; actually all four CREATE TEXT SEARCH commands could do that.
I pushed it as attached.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| alter_dict_tab_complete-2.patch | text/x-diff | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2020-03-07 22:13:13 | Re: range_agg |
| Previous Message | Tom Lane | 2020-03-07 21:44:48 | Re: Refactor compile-time assertion checks for C/C++ |