| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | James Coleman <jtc331(at)gmail(dot)com> |
| Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Proving IS NOT NULL inference for ScalarArrayOpExpr's |
| Date: | 2019-01-16 18:26:36 |
| Message-ID: | 18321.1547663196@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
James Coleman <jtc331(at)gmail(dot)com> writes:
> One other question on testing: do you think the "calculated array"
> tests are good enough by themselves (i.e., remove the ones with array
> constants of > 100 values)? I dislike that it's not as obvious what's
> going on, but given that the code shouldn't care about array size
> anyway...so if there's an inclination to fewer tests that's the first
> place I'd look at cutting them.
I don't have a strong opinion about that at this point. It might be
clearer once the patch is finished; for now, there's no harm in erring
towards the more-tests direction.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-01-16 18:39:31 | Re: current_logfiles not following group access and instead follows log_file_mode permissions |
| Previous Message | Stephen Frost | 2019-01-16 18:22:12 | Re: current_logfiles not following group access and instead follows log_file_mode permissions |