From: | David Steele <david(at)pgmasters(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Teodor Sigaev <teodor(at)sigaev(dot)ru>, pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Exclude unlogged tables from base backups |
Date: | 2018-03-25 19:59:22 |
Message-ID: | 182a8752-59d1-1f12-5f12-ccb6f7f5fc6e@pgmasters.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On 3/25/18 3:54 PM, Tom Lane wrote:
> David Steele <david(at)pgmasters(dot)net> writes:
>> On 3/25/18 3:22 PM, Tom Lane wrote:
>>> Actually, that code didn't guarantee zero termination under *any*
>>> circumstances; it only happened to work if the stack contained
>>> zeroes to start with.
>
>> Interesting. strncpy() says it will pad the destination with NULLs when
>> src is less than the size provided. Perhaps some compilers don't honor
>> that?
>
> Yeah, but the "size provided" was the number of characters to be copied
> from the source string, not the size of the destination buffer. So
> strncpy didn't think it needed to add any nulls. There's a reason why
> that function is widely disliked --- it's hard to use it in a safe way.
Whoops, how right you are. I'm generally passing destination buffer
size in these cases and totally misread what this was doing.
--
-David
david(at)pgmasters(dot)net
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-03-25 20:15:34 | pgsql: Doc: add example of type resolution in nested UNIONs. |
Previous Message | Tom Lane | 2018-03-25 19:54:56 | Re: pgsql: Exclude unlogged tables from base backups |