| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Craig Ringer <craig(at)postnewspapers(dot)com(dot)au> |
| Cc: | Daniel Migowski <dmigowski(at)ikoffice(dot)de>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #4374: pg_restore does not restore public schema comment |
| Date: | 2008-08-26 03:27:40 |
| Message-ID: | 18253.1219721260@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Craig Ringer <craig(at)postnewspapers(dot)com(dot)au> writes:
> The issue actually appears to be that the comment on default schema like
> `public' isn't dumped in the first place.
Hmm ... there is a specific exclusion in _printTocEntry to suppress
dumping of either the CREATE SCHEMA command for "public" or its comment.
I don't quite recall the reasoning [ digs... ] Oh, here it is:
http://archives.postgresql.org/pgsql-committers/2008-01/msg00212.php
You can probably find some related discussion in the archives right
before that, but the commit message is clear enough.
On the whole, since "public" is a quasi-built-in object, it doesn't seem
like a very good idea to depend on being able to alter its properties.
Why not attach your version comment to some other, entirely user-defined
object? "CREATE SCHEMA version" perhaps ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2008-08-26 04:49:45 | Re: non-deterministic error related to MIN/MAX optimization |
| Previous Message | Craig Ringer | 2008-08-26 02:45:27 | Re: BUG #4374: pg_restore does not restore public schema comment |