Corey Huinker <corey(dot)huinker(at)gmail(dot)com> writes:
> In src/backend/access/transam/xact.c, I'm noticing a code style
> inconsistency.
> [ to wit, local variable alias for CurrentTransactionState or not ]
> Is this something worth standardizing, and if so, which style do we like
> better?
I can't get excited about changing this. There may be historical
reasons for the differences, eg maybe at one time there was more
than one reference to the struct in IsTransactionState(). Or maybe
it was just different people doing it a bit differently. It's not
really a big enough difference to be a hindrance to readers, IMO
anyway, so I'd leave it alone.
regards, tom lane