| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL Development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: ALTER TABLE DROP COLUMN |
| Date: | 2000-10-06 02:42:42 |
| Message-ID: | 18226.970800162@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp> writes:
>>>> P.S. I've noticed that get_rte_attribute_name() seems to
>>>> break my implementation. I'm not sure if I could solve it.
>>
>> That would be a problem --- rule dumping depends on that code to
>> produce correct aliases, so making it work is not optional.
> Your change has no problem if logical==physical attribute
> numbers.
But if they're not, what do we do? Can we define the order of the
alias-name lists as being one or the other numbering? (Offhand I'd
say it should be logical numbering, but I haven't chased the details.)
If neither of those work, we'll need some more complex datastructure
than a simple list.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hiroshi Inoue | 2000-10-06 03:05:58 | Re: ALTER TABLE DROP COLUMN |
| Previous Message | Tom Lane | 2000-10-06 01:35:02 | Re: query returns incorrect results. |