Re: JUMBLE_SIZE macro in two files

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: bt22nakamorit <bt22nakamorit(at)oss(dot)nttdata(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: JUMBLE_SIZE macro in two files
Date: 2022-10-04 13:16:44
Message-ID: 1817528.1664889404@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

bt22nakamorit <bt22nakamorit(at)oss(dot)nttdata(dot)com> writes:
> queryjumble.c and queryjumble.h both define a macro JUMBLE_SIZE = 1024.
> Since queryjumble.c includes queryjumble.h, the JUMBLE_SIZE definition
> in queryjumble.c should be deleted.

I would go more for taking it out of queryjumble.h. I see no
reason why that constant needs to be world-visible.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-10-04 13:29:36 Re: get rid of Abs()
Previous Message Tom Lane 2022-10-04 13:08:44 Re: [patch] \g with multiple result sets and \watch with copy queries