| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Marko Tiikkaja <marko(at)joh(dot)to>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much |
| Date: | 2017-10-21 15:43:42 |
| Message-ID: | 18157.1508600622@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> Here you go, down to 9.4 where things apply. The same patch can be
> applied for HEAD/10, 9.5/9.6 and 9.4. The 9.4 version just needs to
> have the portion for json as the jsonb functions have been added in
> 9.5, and the json functions are new as of 9.4.
It doesn't seem very nice to have two identical(?) copies of
extract_variadic_args, especially since the same functionality
might be of use elsewhere. I'm almost inclined to say that that
should go in funcapi.c/.h.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-10-21 16:10:36 | Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much |
| Previous Message | Michael Paquier | 2017-10-21 03:40:39 | Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-10-21 16:08:33 | Re: Refactor handling of database attributes between pg_dump and pg_dumpall |
| Previous Message | Haribabu Kommi | 2017-10-21 05:30:38 | Re: Refactor handling of database attributes between pg_dump and pg_dumpall |