| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Amul Sul <sulamul(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Joe Conway <mail(at)joeconway(dot)com>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Error-safe user functions |
| Date: | 2022-12-22 06:10:54 |
| Message-ID: | 1815581.1671689454@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> And here's another for contrib/seg
> I'm planning to commit these two in the next day or so.
I didn't look at the jsonpath one yet. The seg patch passes
an eyeball check, with one minor nit: in seg_atof,
+ *result = float4in_internal(value, NULL, "real", value, escontext);
don't we want to use "seg" as the type_name?
Even more nitpicky, in
+seg_yyerror(SEG *result, struct Node *escontext, const char *message)
{
+ if (SOFT_ERROR_OCCURRED(escontext))
+ return;
I'd be inclined to add some explanation, say
+seg_yyerror(SEG *result, struct Node *escontext, const char *message)
{
+ /* if we already reported an error, don't overwrite it */
+ if (SOFT_ERROR_OCCURRED(escontext))
+ return;
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Anton A. Melnikov | 2022-12-22 06:59:18 | Re: [BUG] pg_upgrade test fails from older versions. |
| Previous Message | Masahiko Sawada | 2022-12-22 06:08:59 | Re: Perform streaming logical transactions by background workers and parallel apply |