| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Blindly try to fix test script's tar invocation for MSYS. |
| Date: | 2021-03-20 15:05:16 |
| Message-ID: | 181059.1616252716@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 3/18/21 10:43 PM, Tom Lane wrote:
>> Buildfarm member fairywren doesn't like the test case I added
>> in commit 081876d75. I'm guessing the reason is that I shouldn't
>> be using a perl2host-ified path in the tar command line.
> No, you shouldn't. The rule is that you need to use perl2host when
> passing a path to a non-msys-aware program. This will typically be one
> of our own artefacts, or the comand processor (via system(), qx() etc.).
> But msys-aware programs such as utility programs like tar should get the
> path just as the perl script sees it.
Ah. So it seems like the $64 question is how to know that tar, or any
particular other program, is msys-aware.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2021-03-20 16:07:45 | Re: pgsql: Blindly try to fix test script's tar invocation for MSYS. |
| Previous Message | Andrew Dunstan | 2021-03-20 12:20:59 | Re: pgsql: Blindly try to fix test script's tar invocation for MSYS. |