| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Ajin Cherian <itsajin(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: Synchronizing slots from primary to standby |
| Date: | 2023-10-23 06:50:45 |
| Message-ID: | 1803aec2-9af1-446f-ad46-c9dfa8f74b70@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 10/18/23 6:43 AM, shveta malik wrote:
> On Tue, Oct 17, 2023 at 9:06 PM Drouvot, Bertrand
>> +static void
>> +ProcessRepliesAndTimeOut(void)
>> +{
>> + CHECK_FOR_INTERRUPTS();
>> +
>> + /* Process any requests or signals received recently */
>> + if (ConfigReloadPending)
>> + {
>> + ConfigReloadPending = false;
>> + ProcessConfigFile(PGC_SIGHUP);
>> + SyncRepInitConfig();
>> + SlotSyncInitConfig();
>> + }
>>
>> Do we want to do this at each place ProcessRepliesAndTimeOut() is being
>> called? I mean before this change it was not done in ProcessPendingWrites().
>>
>
> Are you referring to ConfigReload stuff ? I see that even in
> ProcessPendingWrites(), we do it after WalSndWait(). Now only the
> order is changed, it is before WalSndWait() now.
Yeah and the CFI.
With the patch the CFI and check on ConfigReloadPending is done in all the case
as the break (if !pq_is_send_pending()) is now done after. That seems ok, just
wanted to mention it.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2023-10-23 07:18:58 | Re: Show version of OpenSSL in ./configure output |
| Previous Message | Peter Eisentraut | 2023-10-23 06:30:28 | Add trailing commas to enum definitions |