| From: | "Higuchi, Daisuke" <higuchi(dot)daisuke(at)jp(dot)fujitsu(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [Bug fix]If recovery.conf has target_session_attrs=read-write, the standby fails to start. |
| Date: | 2017-05-19 07:05:30 |
| Message-ID: | 1803D792815FC24D871C00D17AE95905B1A4CA@g01jpexmbkw24 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
From: Michael Paquier [mailto:michael(dot)paquier(at)gmail(dot)com]
> if (!PQsendQuery(conn,
>- "show transaction_read_only"))
>+ "SHOW transaction_read_only"))
>Or perhaps the replication command parser could be made more flexible with lower-case characters for replication commands?
By adding flex option '-i', replication command parser could be more flexible.
# repl_scanner is compiled as part of repl_gram
repl_gram.o: repl_scanner.c
+repl_scanner.c: FLEXFLAGS = -CF -p -i
This option is already used for syncrep_scanner.c, so it is not strange to add for repl_scanner.c too.
Attached patch also fixes this problem.
Regards,
Daisuke, Higuchi
| Attachment | Content-Type | Size |
|---|---|---|
| flexible_replication_command_parser_v1.patch | application/octet-stream | 462 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2017-05-19 07:46:39 | Redundant check of em_is_child |
| Previous Message | Jeff Davis | 2017-05-19 06:36:39 | Hash Functions |