| From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Sergei Kornilov <sk(at)zsrv(dot)org> |
| Subject: | Re: Continue work on changes to recovery.conf API |
| Date: | 2018-11-25 21:51:11 |
| Message-ID: | 17b4b878-d6ca-3950-935e-c3a539285612@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 25/11/2018 21:48, Stephen Frost wrote:
> Greetings,
>
> On Sun, Nov 25, 2018 at 15:39 Andres Freund <andres(at)anarazel(dot)de
> <mailto:andres(at)anarazel(dot)de>> wrote:
>
> Hi,
>
> On 2018-11-25 13:24:15 -0500, Stephen Frost wrote:
> > - User performs a backup with pg_basebackup -R
> > - Replica is then promoted to be a primary
> > - User performs a backup with pg_basebackup -R on the new primary
> > - Duplicate entries end up in postgresql.auto.conf. Ew.
>
> Why don't we put recovery entries into postgresql.recovery.conf or such?
> And overwrite rather than append?
>
>
> Sure, I think that’s more or less the same thing..? Another included
> file, but one specifically for recovery bits.
I think the important part there is overwrite rather than append. Given
that postgresql.auto.conf is used by ALTER SYSTEM, doing overwrites
there is not as straightforward proposition (behaviorally) as doing it
in another included file.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-11-25 22:14:41 | Python versions (was Re: RHEL 8.0 build) |
| Previous Message | Andres Freund | 2018-11-25 21:51:09 | Re: RHEL 8.0 build |