From: | "Andrew Dunstan" <andrew(at)dunslane(dot)net> |
---|---|
To: | <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCHES] log session end - again |
Date: | 2004-02-04 00:50:51 |
Message-ID: | 1797.24.211.141.25.1075855851.squirrel@www.dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Tom Lane said:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> Right. And if we have sessionids we would want them logged there, I
>> think. And that would rule out anything based on xid or backend pid.
>
> Uh, what's wrong with backend pid? Since we fork before we start doing
> anything with a connection, it should surely be available soon enough
> for the connection log message.
>
> Larry's idea about combining PID and backend start time didn't sound
> too unreasonable to me.
>
It did to me too. I was just looking at this code 2 days ago. Somehow when
I looked again I thought we logged connections in the postmaster. Larry's
idea should work just fine. For log compactness I think I'd hexencode it -
the SessionID doesn't need any semantics, it's just like a cookie.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2004-02-04 01:03:42 | Re: log session end - again |
Previous Message | Jan Wieck | 2004-02-04 00:25:27 | BgWriter sync option backed out |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2004-02-04 01:03:42 | Re: log session end - again |
Previous Message | Magnus Hagander | 2004-02-03 23:46:02 | New win32 signals patch (3) |