| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Bugs in copyfuncs/equalfuncs support for JSON node types |
| Date: | 2022-07-05 01:23:08 |
| Message-ID: | 1794155.1656984188@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
In reviewing Peter's patch to auto-generate the backend/nodes
support files, I compared what the patch's script produces to
what is in the code now. I found several discrepancies in the
recently-added parse node types for JSON functions, and as far
as I can see every one of those discrepancies is an error in
the existing code. Some of them are relatively harmless
(e.g. COPY_LOCATION_FIELD isn't really different from
COPY_SCALAR_FIELD), but some of them definitely are live bugs.
I propose the attached patch.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| fix-json-copy-equal-bugs.patch | text/x-diff | 2.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhihong Yu | 2022-07-05 01:48:48 | Re: Bugs in copyfuncs/equalfuncs support for JSON node types |
| Previous Message | Michael Paquier | 2022-07-05 01:19:49 | Re: avoid multiple hard links to same WAL file after a crash |