| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Inconvenience of pg_read_binary_file() |
| Date: | 2022-07-30 03:35:36 |
| Message-ID: | 179060.1659152136@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Fri, Jul 29, 2022 at 03:44:25PM -0400, Tom Lane wrote:
>> Pushed after some fooling with the docs and test cases. (Notably,
>> I do not think we can assume that pg_hba.conf exists in $PGDATA; some
>> installations keep it elsewhere. I used postgresql.auto.conf instead.)
> Are you sure that this last part is a good idea? We don't force the
> creation of postgresql.auto.conf when starting a server, so this
> impacts the portability of the tests with installcheck if one decides
> to remove it from the data folder, and it sounds plausible to me that
> some distributions do exactly that..
Hm. I considered reading PG_VERSION instead, or postmaster.pid.
PG_VERSION would be a very boring test case, but it should certainly
be present in $PGDATA.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2022-07-30 03:45:03 | Re: making relfilenodes 56 bits |
| Previous Message | Michael Paquier | 2022-07-30 02:37:02 | Re: Inconvenience of pg_read_binary_file() |