| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: invalid memory alloc request size error with commit 4b93f579 |
| Date: | 2018-02-26 21:25:25 |
| Message-ID: | 17898.1519680325@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> I wonder whether it is worth creating a C trigger function
> (probably in regress.c) specifically to exercise this situation.
Actually, that doesn't seem too bad at all. I propose applying
and back-patching the attached.
BTW, I noticed while doing this that the adjacent "funny_dup17"
trigger is dead code, and has been since commit 1547ee01 of
1999-09-29. I'm inclined to rip it out, because anyone looking
at regress.c would naturally assume that anything in there is
being exercised.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| before_trigger_fix-2.patch | text/x-diff | 4.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-02-26 21:28:36 | Re: RTLD_GLOBAL (& JIT inlining) |
| Previous Message | Bear Giles | 2018-02-26 20:40:07 | Re: Precision loss casting float to numeric |