| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Philip Warner <pjw(at)rhyme(dot)com(dot)au> |
| Cc: | Neil Conway <neilc(at)samurai(dot)com>, "Christopher Kings-Lynne" <chriskl(at)familyhealth(dot)com(dot)au>, "Hackers" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump in 7.4 |
| Date: | 2002-11-14 19:35:37 |
| Message-ID: | 17859.1037302537@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Philip Warner <pjw(at)rhyme(dot)com(dot)au> writes:
> At 12:39 AM 14/11/2002 -0500, Neil Conway wrote:
>> Perhaps when the function is defined, we run all the SQL queries in
>> the function body through the parser/analyzer/rewriter, and then
>> generate dependencies on the Query trees we get back?
> Won't work for functions that build dynamic queries.
That's irrelevant for SQL functions, though, and pg_dump does not need
to worry about dependencies inside other types of functions (since only
SQL functions' bodies are examined during CREATE FUNCTION).
Neil's solution is exactly what I was thinking we should do. Or almost
exactly, anyway: we don't want to run the rewriter before extracting
dependencies.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephan Szabo | 2002-11-14 20:01:49 | Re: create or replace view |
| Previous Message | Scott Shattuck | 2002-11-14 19:26:53 | Re: create or replace view |