From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
Cc: | pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pgsql: Make heap TID a tiebreaker nbtree index column. |
Date: | 2019-03-20 21:50:45 |
Message-ID: | 17845.1553118645@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Peter Geoghegan <pg(at)bowt(dot)ie> writes:
> On Wed, Mar 20, 2019 at 2:44 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> After trying it (against yesterday's sources) on my SELinux-capable
>> machine, I see no evidence that we need any output ordering changes
>> at all if we go this route. This is probably unsurprising considering
>> that the old btree code used to provide mostly-reverse-insertion-order
>> scan order.
> That's good. I'm trying to fix it by hand right now, in the way that
> Andres suggested. It is both tedious and error-prone.
Yeah. Don't do that.
After further thought I think I'll go with the alternate solution
(separate sortObjectAddresses function) as that could possibly have
other uses, and removing the "const" from performMultipleDeletions
seems a bit bletcherous. Will push a fix in a few minutes.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-03-20 22:06:39 | pgsql: Sort the dependent objects before deletion in DROP OWNED BY. |
Previous Message | Peter Geoghegan | 2019-03-20 21:47:58 | Re: pgsql: Make heap TID a tiebreaker nbtree index column. |